promptdojo_

Acceptance before the build — review against checks, not vibes — step 7 of 8

Write review_deliverable(d, checks) — the full gate, now with the blocking flag doing its job. Return (verdict, failing_ids).

  • failing_ids: every check (in checks order) whose recorded result in d["results"] is not "pass" — missing records fail, as always.
  • Verdict, exactly one of three:
    • any failing check has blocking: True"REWORK"
    • failures exist but none are blocking → "ACCEPT-WITH-NOTES"
    • no failures → "ACCEPT"

failing_ids lists ALL failures either way — a blocking failure doesn't hide the non-blocking ones from the rework note.

Four deliverables run. Expected output:

D-21: ACCEPT
D-22: ACCEPT-WITH-NOTES — C3
D-23: REWORK — C1
D-24: REWORK — C1, C3

full-screen editor opens — close anytime to keep reading.